Oved Ourfali has posted comments on this change. Change subject: core: introduce context pattern ......................................................................
Patch Set 34: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28829/34/backend/manager/modules/bll/exclude-filters.xml File backend/manager/modules/bll/exclude-filters.xml: Line 106: <Match> Line 107: <Class name="org.ovirt.engine.core.bll.context.EngineContext" /> Line 108: <Method name="clone" /> Line 109: <Bug pattern="CN_IDIOM_NO_SUPER_CALL" /> Line 110: no need for whitespace here. Line 111: <Match> Line 112: <Class name="org.ovirt.engine.core.bll.Backend" /> Line 113: <Method name="initialize" /> Line 114: <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" /> -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches