Moti Asayag has posted comments on this change. Change subject: engine: Fix coverity complains ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29072/1/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java: Line 9: Line 10: public class DuplicateKeysCheck { Line 11: public static void assertNoDuplicateKeys(String filePath) throws FileNotFoundException { Line 12: NoDuplicateProperties props = new NoDuplicateProperties(); Line 13: try (InputStream is = new FileInputStream(filePath)) { the complain here is about resource leakage... Line 14: props.load(is); Line 15: } Line 16: catch (Exception exception) { Line 17: fail("Check for duplicate keys in " + filePath + " failed: " + exception.getMessage()); -- To view, visit http://gerrit.ovirt.org/29072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88c2d7a1c4aab7261e9ddf5b69de127353f4a410 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
