[Engine-patches] Change in ovirt-engine[master]: engine: Fix coverity complains

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: engine: Fix coverity complains
......................................................................

engine: Fix coverity complains

Change-Id: I88c2d7a1c4aab7261e9ddf5b69de127353f4a410
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
M 
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java
2 files changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/29072/1

diff --git 
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
 
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
index 004243e..70f614e 100644
--- 
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
+++ 
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
@@ -9,14 +9,12 @@
 
 public class DuplicateKeysCheck {
     public static void assertNoDuplicateKeys(String filePath) throws 
FileNotFoundException {
-        InputStream is = new FileInputStream(filePath);
         NoDuplicateProperties props = new NoDuplicateProperties();
-        try {
+        try (InputStream is = new FileInputStream(filePath)) {
             props.load(is);
         }
         catch (Exception exception) {
             fail("Check for duplicate keys in " + filePath + " failed: " + 
exception.getMessage());
         }
-
     }
 }
diff --git 
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java
 
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java
index 1cd5319..78de3ec 100644
--- 
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java
+++ 
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java
@@ -2,6 +2,7 @@
 
 import java.util.Properties;
 
+@SuppressWarnings("serial")
 public class NoDuplicateProperties extends Properties {
     /**
      * This method overrides the put method of Map in order to add the 
validation


-- 
To view, visit http://gerrit.ovirt.org/29072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88c2d7a1c4aab7261e9ddf5b69de127353f4a410
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches