Yair Zaslavsky has posted comments on this change. Change subject: engine:Fixed error message Add/remove/update Gluster Hook ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28841/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java: Line 69: Line 70: for (GlusterServerHook serverHook: getMissingServerHooks()) { Line 71: VDS vds = getVdsDAO().get(serverHook.getServerId()); Line 72: if (vds == null || vds.getStatus() != VDSStatus.Up) { Line 73: String vdsName = vds != null ? vds.getName() : "NO SERVER"; consider having this as a constant. Line 74: setVdsName(vdsName); Line 75: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP); Line 76: addCanDoActionMessage(String.format("$%1$s %2$s", "VdsName", vdsName)); Line 77: return false; http://gerrit.ovirt.org/#/c/28841/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java: Line 69: Line 70: for (GlusterServerHook serverHook: getContentConflictServerHooks()) { Line 71: VDS vds = getVdsDAO().get(serverHook.getServerId()); Line 72: if (vds == null || vds.getStatus() != VDSStatus.Up) { Line 73: String vdsName = vds != null ? vds.getName() : "NO SERVER"; same as bfore. maybe considerr having a GlusterConstants class for this? Line 74: setVdsName(vdsName); Line 75: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP); Line 76: addCanDoActionMessage(String.format("$%1$s %2$s", "VdsName", vdsName)); Line 77: return false; -- To view, visit http://gerrit.ovirt.org/28841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If018578d2fe89f9ed10dad948b7bd922033c78e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
