Karnan t c has uploaded a new change for review. Change subject: webadmin:Fix for Gluster hook resolve conflicts popup not loading ......................................................................
webadmin:Fix for Gluster hook resolve conflicts popup not loading Fix for Gluster hook resolve conflicts popup not loading properly. The issue was with parse method getting an empty string which is not handled appropriately. Change-Id: I7c51cd249552f8cb37f2e3093a1c0ddca764b859 Signed-off-by: Karnan TC <kchid...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/28840/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java index 361322f..e18ac14 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java @@ -186,7 +186,12 @@ statusEditor = new EntityModelLabelEditor<GlusterHookStatus>(new EnumRenderer<GlusterHookStatus>(), new Parser<GlusterHookStatus>() { @Override public GlusterHookStatus parse(CharSequence text) throws ParseException { - return GlusterHookStatus.valueOf(text.toString().toUpperCase()); + if(text == null || text.toString().isEmpty()) { + return null; + } + else { + return GlusterHookStatus.valueOf(text.toString().toUpperCase()); + } } }); -- To view, visit http://gerrit.ovirt.org/28840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c51cd249552f8cb37f2e3093a1c0ddca764b859 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchid...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches