Eli Mesika has posted comments on this change. Change subject: core: [RFE] add support for custom fencing ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/28621/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFenceConfigurationValueQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFenceConfigurationValueQuery.java: Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import org.ovirt.engine.core.common.config.ConfigCommon; > why this indentation. is it just gerrit showing it that way? Done Line 4: import org.ovirt.engine.core.common.config.ConfigValues; Line 5: import org.ovirt.engine.core.common.queries.GetConfigurationValueParameters; Line 6: import org.ovirt.engine.core.utils.pm.FenceConfigHelper; Line 7: Line 39: * <li>If the query is run as a user, it may return results <b>ONLY</b> if the configuration value has {@link org.ovirt.engine.core.common.queries.ConfigurationValues.ConfigAuthType#User}.</li> Line 40: * </ul> Line 41: */ Line 42: private boolean shouldReturnValue() { Line 43: return !getParameters().isFiltered() || !getParameters().getConfigValue().isAdmin(); > Do we want users to be able to query that, in the use-cases it is used toda It works as teh regular config query works so should have the same credentials Line 44: } -- To view, visit http://gerrit.ovirt.org/28621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie887b9025d0813c4d101a886614364127aea75a0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
