Eli Mesika has posted comments on this change. Change subject: core: [RFE] add support for custom fencing ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/28621/5/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/FenceConfigHelper.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/FenceConfigHelper.java: Line 14: private static HashMap<String, String> keyValidatorExampleMap; Line 15: private static HashMap<String, String> keySeparatorMap; Line 16: private static Log log; Line 17: private static boolean initialized=false; Line 18: private static final String FenceAgentMappingExpr="((\\w)+[=](\\w)+[,]{0,1})+"; > I wonder if it will be able pass checkstyle without spaces around assignmen Done Line 19: private static final String FenceAgentDefaultParamsExpr="([\\w]+([=][\\w]+){0,1}[,]{0,1})+"; Line 20: private static final String VdsFenceOptionMappingExpr="([\\w]+[:]([\\w]*[=][\\w]*[,]{0,1}[;]{0,1}){0,3}[;]{0,1})+"; Line 21: private static final String CustomVdsFenceTypeExpr="((\\w)+[,]{0,1})+"; Line 22: private static final String COMMA=","; http://gerrit.ovirt.org/#/c/28621/5/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/FenceConfigValueHelper.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/FenceConfigValueHelper.java: Line 18: String validator = FenceConfigHelper.getValidator(key); Line 19: if (StringUtils.isNotEmpty(validator)) { Line 20: if (! value.matches(validator)) { Line 21: return new ValidationResult(false, Line 22: String.format("The entered key value is invalid. Value should match expression %s. Example: %s", validator, FenceConfigHelper.getValidatorExample(key))); > I would place values inside ''. Done Line 23: } Line 24: else { Line 25: return new ValidationResult(true); Line 26: } http://gerrit.ovirt.org/#/c/28621/5/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 398: # Reports link Line 399: RedirectServletReportsPage.description="Redirection target for Reports link" Line 400: RedirectServletReportsPage.type=String Line 401: # Custome fence agents configurations Line 402: CustomFenceAgentMapping.description="Maps a fencing agent to other agent implicitly. Format : ((\\w)+[=](\\w)+[,]{0,1})+. Example:agent1=agent2,agent3=agent4" > Please add space after 'Example:' Done Line 403: CustomFenceAgentMapping.type=FenceConfig Line 404: CustomFenceAgentDefaultParams.description="Default parameters per agent. Format ([\\w]+([=][\\w]+){0,1}[,]{0,1})+. Example:agent1=key1=val1,flag;key2=val2" Line 405: CustomFenceAgentDefaultParams.type=FenceConfig Line 406: CustomVdsFenceOptionMapping.description="secure/port/slot mapping support per agent. Format ([\\w]+[:]([\\w]*[=][\\w]*[,]{0,1}[;]{0,1}){0,3}[;]{0,1})+. Example:agent1:secure=secure;agent2:port=ipport,slot=slot" -- To view, visit http://gerrit.ovirt.org/28621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie887b9025d0813c4d101a886614364127aea75a0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
