Greg Padgett has posted comments on this change. Change subject: engine : Add callback enabled commands to CommandExecutor callback map ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28724/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2094: } Line 2095: Line 2096: public void persistCommand(VdcActionType parentCommand, boolean enableCallBack) { Line 2097: VdcActionParametersBase parentParameters = getParentParameters(parentCommand); Line 2098: Transaction transaction = TransactionSupport.suspend(); > Please elaborate why you're suspending the transaction here. This prevents a deadlock from occurring due to command_entities contention when persistAsyncTaskPlaceholder() is run by a command started by CommandExecutor. Without this change, or a NonTransactiveCommandAttribute, the command hangs when trying to start the SPM task. Line 2099: try { Line 2100: TaskManagerUtil.persistCommand( Line 2101: CommandEntity.buildCommandEntity(getCommandId(), Line 2102: parentParameters.getCommandId(), -- To view, visit http://gerrit.ovirt.org/28724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9765a947d3772fbc47a1adaa91cd54da9ba202bb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
