Yair Zaslavsky has posted comments on this change. Change subject: engine : Add callback enabled commands to CommandExecutor callback map ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/28724/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2094: } Line 2095: Line 2096: public void persistCommand(VdcActionType parentCommand, boolean enableCallBack) { Line 2097: VdcActionParametersBase parentParameters = getParentParameters(parentCommand); Line 2098: Transaction transaction = TransactionSupport.suspend(); Please elaborate why you're suspending the transaction here. what did you try to achieve? Line 2099: try { Line 2100: TaskManagerUtil.persistCommand( Line 2101: CommandEntity.buildCommandEntity(getCommandId(), Line 2102: parentParameters.getCommandId(), Line 2110: } Line 2111: } Line 2112: Line 2113: protected void removeCommand() { Line 2114: Transaction transaction = TransactionSupport.suspend(); same here.. Line 2115: try { Line 2116: TaskManagerUtil.removeCommand(getCommandId()); Line 2117: } finally { Line 2118: TransactionSupport.resume(transaction); Line 2125: Line 2126: public void setCommandStatus(CommandStatus status, boolean updateDB) { Line 2127: this.commandStatus = status; Line 2128: if (updateDB) { Line 2129: Transaction transaction = TransactionSupport.suspend(); same. Line 2130: try { Line 2131: TaskManagerUtil.updateCommandStatus(getCommandId(), getTaskType(), commandStatus); Line 2132: } finally { Line 2133: TransactionSupport.resume(transaction); -- To view, visit http://gerrit.ovirt.org/28724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9765a947d3772fbc47a1adaa91cd54da9ba202bb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
