Arik Hadas has posted comments on this change. Change subject: core: process VMs that went down on separate thread ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28220/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 111: for (final Guid vmId : vmIds) { Line 112: ThreadPoolUtil.execute(new Runnable() { Line 113: @Override Line 114: public void run() { Line 115: Backend.getInstance().runInternalAction(VdcActionType.ProcessDownVm, > I realize I confused that with another flow. doing those operations in different threads can be important in terms of correctness: let's say you have VM X which is HA and it went down after next-conf was defined and there're many stateless VMs which are before that one in the list, so the probability that we'll try to restart X before applying the next-conf is increased (because we'll need to restore the stateless snapshot for each of the VMs before applying the next-conf of X). The question I think is not whether single thread is enough, because in some cases it is not, but what is the probability that this change will make things worse.. Line 116: new IdParameters(vmId)); Line 117: } Line 118: }); Line 119: } -- To view, visit http://gerrit.ovirt.org/28220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I903992087c7d5975548746f45451fccbfd38b299 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
