Arik Hadas has posted comments on this change. Change subject: core: process VMs that went down on separate thread ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28220/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 111: for (final Guid vmId : vmIds) { Line 112: ThreadPoolUtil.execute(new Runnable() { Line 113: @Override Line 114: public void run() { Line 115: Backend.getInstance().runInternalAction(VdcActionType.ProcessDownVm, > spin a new thread per each? why not 1 thread per this whole iteration if we There's no call for Destroy from within ProcessDownVmCommand.. But yeah, there is a call to RestoreStatelessSnapshot which is going to the SPM. Since we're going to remove the SPM, we might be able to parallelize those calls to different hosts + in case of non-stateless VMs there's no reason why not doing in different threads (but then it's just short task). I don't mind to change the order such that the loop will be make in the Runnable implementation if you insist, I don't think it's necessary though because you have an assumption on the SPM existence which might change soon. Line 116: new IdParameters(vmId)); Line 117: } Line 118: }); Line 119: } -- To view, visit http://gerrit.ovirt.org/28220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I903992087c7d5975548746f45451fccbfd38b299 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
