Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: WebSocketProxy on a separate host ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/28534/11/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/localwsp.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/localwsp.py: Line 64: self.environment[oenginecons.PKIEnv.ORG], Line 65: self.environment[osetupcons.ConfigEnv.FQDN], Line 66: ), Line 67: ), Line 68: ) > It's what I've done (or tried to at least): no... I mean that the engine plugin should enroll the certificate, and websocket proxy to use it if available or prompt user. this way this plugin will be much more simple. Line 69: self.environment[ Line 70: otopicons.CoreEnv.MODIFIED_FILES Line 71: ].extend( Line 72: ( -- To view, visit http://gerrit.ovirt.org/28534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifceddd5aa44a77f67a3b6b30c6678d9a3b485f9c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
