Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: WebSocketProxy on a separate host
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/28534/11/packaging/setup/ovirt_engine_setup/websocket_proxy/wspconstants.py
File packaging/setup/ovirt_engine_setup/websocket_proxy/wspconstants.py:

Line 54:         OVIRT_ENGINE_PKIDIR,
Line 55:         'keys',
Line 56:     )
Line 57:     OVIRT_ENGINE_PKICERTSDIR = os.path.join(
Line 58:         OVIRT_ENGINE_PKIDIR,
> upgrade support is targeted to post feature freeze. I agree on having it in
this patch is not to be merged at all it is very far from being complete, and 
have lots of security issues, and if any delay to 3.6
Line 59:         'certs',
Line 60:     )
Line 61: 
Line 62:     OVIRT_ENGINE_PKI_WEBSOCKET_PROXY_STORE = os.path.join(


-- 
To view, visit http://gerrit.ovirt.org/28534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifceddd5aa44a77f67a3b6b30c6678d9a3b485f9c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to