Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: refactor db credentials questions ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/28261/9/packaging/setup/ovirt_engine_setup/engine_common/constants.py File packaging/setup/ovirt_engine_setup/engine_common/constants.py: Line 157 Line 158 Line 159 Line 160 Line 161 why do we need this at common? Line 157: 'password': EngineDBEnv.PASSWORD, Line 158: 'database': EngineDBEnv.DATABASE, Line 159: 'connection': EngineDBEnv.CONNECTION, Line 160: 'pgpassfile': EngineDBEnv.PGPASS_FILE, Line 161: 'newDatabase': EngineDBEnv.NEW_DATABASE, why do we need this at common? Line 162: } Line 163: Line 164: @classproperty Line 165: def DEFAULT_ENGINE_DB_ENV_KEYS(self): -- To view, visit http://gerrit.ovirt.org/28261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1451e581a89b750ab34c09e34faeb77403909f00 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
