Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: refactor db credentials questions ......................................................................
Patch Set 9: (3 comments) this patch should have been squashed somewhere else. http://gerrit.ovirt.org/#/c/28261/9/packaging/setup/ovirt_engine_setup/engine_common/constants.py File packaging/setup/ovirt_engine_setup/engine_common/constants.py: Line 157 Line 158 Line 159 Line 160 Line 161 > removed from here in http://gerrit.ovirt.org/#/c/28646/2/packaging/setup/ov so there is no reason for this patch, only makes review harder. http://gerrit.ovirt.org/#/c/28261/9/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: Line 590: # errors. We currently always have one about plpgsql already Line 591: # existing. When doing that, verify with both pg 8 and 9. Line 592: ) Line 593: Line 594: def _checkDbEncoding(self, environment, name): so we added it there at one patch and move it in this one... this split is not meant to be. Line 595: Line 596: statement = Statement( Line 597: environment=environment, Line 598: dbenvkeys=self._dbenvkeys, Line 620: def getCredentials( Line 621: self, Line 622: name, Line 623: queryprefix, Line 624: defaultdbenvkeys, we should be able to work without defaults. as consumer can have none. so it should be optional. Line 625: show_create_msg=False Line 626: ): Line 627: interactive = None in ( Line 628: self.environment[self._dbenvkeys['host']], -- To view, visit http://gerrit.ovirt.org/28261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1451e581a89b750ab34c09e34faeb77403909f00 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
