Moti Asayag has posted comments on this change. Change subject: common: Introduce profiles package & Disk Profile ......................................................................
Patch Set 6: (2 comments) few minor comments. http://gerrit.ovirt.org/#/c/27098/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java: Line 31: private ProfileBase() { Line 32: } Line 33: Line 34: public ProfileBase(ProfileType profileType) { Line 35: this(); the call to this c'tor isn't needed. Line 36: this.setProfileType(profileType); Line 37: } Line 38: Line 39: @Override http://gerrit.ovirt.org/#/c/27098/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileType.java: Line 5: Line 6: import org.ovirt.engine.core.common.businessentities.Identifiable; Line 7: Line 8: public enum ProfileType implements Identifiable { Line 9: DISK(1); why not to start from 0 ? Line 10: Line 11: private final int value; Line 12: private static final Map<Integer, ProfileType> valueToStatus = new HashMap<Integer, ProfileType>(); Line 13: -- To view, visit http://gerrit.ovirt.org/27098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af22277b50554531511002f19046c0051d8ff Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
