Gilad Chaplik has posted comments on this change. Change subject: common: Introduce profiles package & Disk Profile ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27098/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileType.java: Line 8: DISK(0), Line 9: VNIC(1); Line 10: Line 11: private final int value; Line 12: private static final HashMap<Integer, ProfileType> valueToStatus = new HashMap<Integer, ProfileType>(); > I use standard oVirt coding styles. prefer to leave it as it is. got confused by another comment. sorry. Done. Line 13: Line 14: static { Line 15: for (ProfileType status : values()) { Line 16: valueToStatus.put(status.getValue(), status); -- To view, visit http://gerrit.ovirt.org/27098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af22277b50554531511002f19046c0051d8ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches