Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: Introduce plugin for fence_kdump listener ......................................................................
Patch Set 12: (5 comments) http://gerrit.ovirt.org/#/c/27486/12/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 227: RPM_VERSION = config.RPM_VERSION Line 228: RPM_RELEASE = config.RPM_RELEASE Line 229: Line 230: USER_ADMIN = 'admin' Line 231: FENCE_KDUMP_LISTENER_SERVICE_NAME = 'ovirt-fence-kdump-listener' > oh... this should move into engine constants now... after merge of split en engine constants split has been already merged; this constants it's engine specific so it has to in packaging/setup/ovirt_engine_setup/engine/engineconstants.py relegating it to the engine package and not to base Line 232: Line 233: @classproperty Line 234: def RPM_LOCK_LIST_SUFFIXES(self): Line 235: return ( Line 381: summary=True, Line 382: description=_('Configure fence_kdump listener'), Line 383: postinstallfile=True, Line 384: ) Line 385: def FENCE_KDUMP_LISTENER_CONFIG(self): the same here Line 386: return 'OVESETUP_CONFIG/fenceKdumpListenerConfig' Line 387: Line 388: Line 389: @util.export http://gerrit.ovirt.org/#/c/27486/12/packaging/setup/plugins/ovirt-engine-common/base/core/fence_kdump_listener.py File packaging/setup/plugins/ovirt-engine-common/base/core/fence_kdump_listener.py: this, being engine specific, should be moved to packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/fence_kdump_listener.py Line 1: # Line 2: # ovirt-engine-setup -- ovirt engine setup Line 3: # Copyright (C) 2014 Red Hat, Inc. Line 4: # http://gerrit.ovirt.org/#/c/27486/12/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/fence_kdump_listener.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/fence_kdump_listener.py: Line 35: """fence_kdump listener plugin.""" Line 36: Line 37: @plugin.event( Line 38: stage=plugin.Stages.STAGE_MISC, Line 39: condition=lambda self: not self.environment[ In another patch ( I26017770262e313ad38ddfa96baeaea144c86e5f ) we are going also to split the engine-cleanup part to let the user deconfigure just a a product option. If possible please rebase on that and use this condition condition=lambda self: ( ( self.environment[ osetupcons.RemoveEnv.REMOVE_ALL ] or self.environment[ oenginecons.RemoveEnv.REMOVE_ENGINE ] ) and not self.environment[ osetupcons.CoreEnv.DEVELOPER_MODE ], ), Line 40: osetupcons.CoreEnv.DEVELOPER_MODE Line 41: ], Line 42: ) Line 43: def _misc(self): http://gerrit.ovirt.org/#/c/27486/12/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py: Line 61: ) Line 62: Line 63: @plugin.event( Line 64: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 65: condition=lambda self: self.environment[ on another patch ( I7a7fbc9d2abc141bed49eff20549289cba4a4a61 ) we are going to let the user skip the engine installation (for instance to install only DWH). Can you please rebase on that and check also the status of this oenginecons.CoreEnv.ENABLE in this kind of condition? Line 66: osetupcons.ConfigEnv.FENCE_KDUMP_LISTENER_CONFIG Line 67: ], Line 68: before=( Line 69: osetupcons.Stages.DIALOG_TITLES_E_SYSTEM, -- To view, visit http://gerrit.ovirt.org/27486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
