Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: Introduce plugin for fence_kdump listener
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

please notice this is a conflict without conflict...

http://gerrit.ovirt.org/#/c/27486/12/packaging/setup/ovirt_engine_setup/constants.py
File packaging/setup/ovirt_engine_setup/constants.py:

Line 227:     RPM_VERSION = config.RPM_VERSION
Line 228:     RPM_RELEASE = config.RPM_RELEASE
Line 229: 
Line 230:     USER_ADMIN = 'admin'
Line 231:     FENCE_KDUMP_LISTENER_SERVICE_NAME = 'ovirt-fence-kdump-listener'
oh... this should move into engine constants now... after merge of split engine.
Line 232: 
Line 233:     @classproperty
Line 234:     def RPM_LOCK_LIST_SUFFIXES(self):
Line 235:         return (


-- 
To view, visit http://gerrit.ovirt.org/27486
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I052cc2296c479caf58d0930a8e678298dde63517
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to