Oved Ourfali has posted comments on this change. Change subject: core: Foreman discovery host integration to ovirt ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/27621/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 360: vds_byHostName.getStaticData(), "" , false); Line 361: parameters.setShouldBeLogged(false); Line 362: parameters.setTransactionScopeOption(TransactionScopeOption.RequiresNew); Line 363: Line 364: // If host exists in InstallingOs status, remove it from DB and move on Why are we removing it? Can't we just work with it? Line 365: final VDS foundVds = DbFacade.getInstance().getVdsDao().getByName(parameters.getVdsStaticData().getName()); Line 366: if ((foundVds != null) && (foundVds.getDynamicData().getStatus() == VDSStatus.InstallingOS)) { Line 367: TransactionSupport.executeInScope(TransactionScopeOption.Required, new TransactionMethod<Void>() { Line 368: @Override http://gerrit.ovirt.org/#/c/27621/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 76: runHttpMethod(httpClient, httpMethod); Line 77: ForemanHostWrapper fhw = objectMapper.readValue(httpMethod.getResponseBody(), ForemanHostWrapper.class); Line 78: return mapHosts(Arrays.asList(fhw.getResults())); Line 79: } catch (Exception e) { Line 80: return null; why aren't we calling handleException anymore? Line 81: } Line 82: } Line 83: Line 84: private List<ExternalDiscoveredHost> runDiscoveredHostListMethod(HttpMethod httpMethod) { -- To view, visit http://gerrit.ovirt.org/27621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c25a544373d8ab4a7123137c8a4697205a8efa8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
