Yaniv Bronhaim has posted comments on this change. Change subject: core: Foreman discovery host integration to ovirt ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/27621/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 76: runHttpMethod(httpClient, httpMethod); Line 77: ForemanHostWrapper fhw = objectMapper.readValue(httpMethod.getResponseBody(), ForemanHostWrapper.class); Line 78: return mapHosts(Arrays.asList(fhw.getResults())); Line 79: } catch (Exception e) { Line 80: return null; > why aren't we calling handleException anymore? handle exception continues the throwing. we need to return here to allow fronend query to know about the failure Line 81: } Line 82: } Line 83: Line 84: private List<ExternalDiscoveredHost> runDiscoveredHostListMethod(HttpMethod httpMethod) { -- To view, visit http://gerrit.ovirt.org/27621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c25a544373d8ab4a7123137c8a4697205a8efa8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
