Alon Bar-Lev has posted comments on this change. Change subject: reports: Split of engine-setup-plugin ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/28243/9/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py: Line 62: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 63: filetransaction.FileTransaction( Line 64: # TODO: ES: reports.xls it's now just copied locally Line 65: # under the desidered path, find a way to push it Line 66: # to the engine to enable multi-host setup please remove the comment, we are not dealing with multi host now. Line 67: name=os.path.join( Line 68: osetupcons.FileLocations.OVIRT_SETUP_LOCALSTATEDIR, Line 69: 'reports.xml', Line 70: ), Line 64: # TODO: ES: reports.xls it's now just copied locally Line 65: # under the desidered path, find a way to push it Line 66: # to the engine to enable multi-host setup Line 67: name=os.path.join( Line 68: osetupcons.FileLocations.OVIRT_SETUP_LOCALSTATEDIR, please copy this into the reports environment, as setup can move and we need the engine always. Line 69: 'reports.xml', Line 70: ), Line 71: content=content.read(), Line 72: modifiedList=uninstall_files, -- To view, visit http://gerrit.ovirt.org/28243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1849f9f06523d5926b7e8cf35399cedb5146c718 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
