Simone Tiraboschi has posted comments on this change. Change subject: reports: Split of engine-setup-plugin ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28243/8/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py: Line 60: "r", Line 61: ) as content: Line 62: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 63: filetransaction.FileTransaction( Line 64: name=oreportscons.FileLocations.OVIRT_ENGINE_REPORTS_UI, > no... you must copy it into engine, leave it as-is for this patch, we need The "problem" is that FileLocations.OVIRT_ENGINE_LOCALSTATEDIR is now under oenginecons and it should not be seen from here for dependency reason. Should I move FileLocations.OVIRT_ENGINE_LOCALSTATEDIR under engine_common or should I copy (just a local copy for now and maybe some other kind of copy than) that file somewhere else from the engine plugins? Line 65: content=content.read(), Line 66: modifiedList=uninstall_files, Line 67: ) Line 68: ) -- To view, visit http://gerrit.ovirt.org/28243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1849f9f06523d5926b7e8cf35399cedb5146c718 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
