Xiaolei Shi has posted comments on this change. Change subject: core: need vds id when build vm numa properties ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/27830/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java: Line 77: builder.buildVmVirtioScsi(); Line 78: builder.buildVmRngDevice(); Line 79: builder.buildUnmanagedDevices(); Line 80: builder.buildVmSerialNumber(); Line 81: builder.buildVmNumaProperties(getParameters().getVdsId()); > please keep the buildVmNumaProperties a void method and access the vdsId fr Could you show me a way to get the vdsId from inside VmInfoBuilder? In VmInfoBuilder, i only find the VM entity. In VM entity, i think i can get vdsId from getRunOnVds method(actually it's from VmDynamic). But this field was filled after the vm was run in any host successfully, that means in the VM entity in VmInfoBuilder, the value of runOnVds is null(actually it's null after my testing). Or can i use the field(runOnVds) of VM entity to temporarily transmit the value? (ie. I will set the value in CreateVDSCommand so that i can get the value in VmInfoBuilder, after that i will reset it to null) Line 82: } Line 83: Line 84: private static final Log log = LogFactory.getLog(CreateVDSCommand.class); http://gerrit.ovirt.org/#/c/27830/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 432: } Line 433: return vdsGroup; Line 434: } Line 435: Line 436: protected void buildVmNumaProperties(Guid vdsId) { > 1. move this method below buildVmRngDevice Done Line 437: final String compatibilityVersion = vm.getVdsGroupCompatibilityVersion().toString(); Line 438: addNumaSetting(compatibilityVersion, vdsId); Line 439: } -- To view, visit http://gerrit.ovirt.org/27830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19be54812d0ebbb54145f33e6b036af84ff1d8ae Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
