Roy Golan has posted comments on this change. Change subject: core: need vds id when build vm numa properties ......................................................................
Patch Set 6: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/27830/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java: Line 77: builder.buildVmVirtioScsi(); Line 78: builder.buildVmRngDevice(); Line 79: builder.buildUnmanagedDevices(); Line 80: builder.buildVmSerialNumber(); Line 81: builder.buildVmNumaProperties(getParameters().getVdsId()); please keep the buildVmNumaProperties a void method and access the vdsId fron inside Line 82: } Line 83: Line 84: private static final Log log = LogFactory.getLog(CreateVDSCommand.class); http://gerrit.ovirt.org/#/c/27830/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 432: } Line 433: return vdsGroup; Line 434: } Line 435: Line 436: protected void buildVmNumaProperties(Guid vdsId) { 1. move this method below buildVmRngDevice 2. make it abstract as it is not currently supported anyway to older cluster versions 3. move the implentation to VmInfoBuilder 4. move addNumaSettings with it as I think it is also not related for older VMs currently so it doesn't belong here. if(when?) numa will be supported for older VMs then we can move it to the base Line 437: final String compatibilityVersion = vm.getVdsGroupCompatibilityVersion().toString(); Line 438: addNumaSetting(compatibilityVersion, vdsId); Line 439: } -- To view, visit http://gerrit.ovirt.org/27830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19be54812d0ebbb54145f33e6b036af84ff1d8ae Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
