Alon Bar-Lev has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 49: (2 comments) http://gerrit.ovirt.org/#/c/28022/49/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java: Line 69: ctx.close(); Line 70: } Line 71: } Line 72: } catch (Exception ex) { Line 73: log.error("Error in REST-API session management. ", ex); debug stack? Line 74: } Line 75: Line 76: } Line 77: http://gerrit.ovirt.org/#/c/28022/49/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/SessionConstants.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/SessionConstants.java: Line 1: package org.ovirt.engine.core.common.constants; Line 2: Line 3: public class SessionConstants { Line 4: Line 5: public final static String HTTP_SESSION_ENGINE_SESSION_ID_KEY = "engineSessionId"; please re-add ovirt_aaa_ prefix. everything at session container must be unique... the fact that variable is within namespace does not mean it is unique within session. Line 6: -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 49 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
