Alon Bar-Lev has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 48: (4 comments) http://gerrit.ovirt.org/#/c/28022/48/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/SessionConstants.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/SessionConstants.java: Line 1: package org.ovirt.engine.core.common.constants; Line 2: Line 3: public class SessionConstants { Line 4: Line 5: public final static String HTTP_SESSION_ENGINE_SESSION_ID_KEY = "engineSessionId"; why have we removed the ovirt_aaa_ prefix? Line 6: http://gerrit.ovirt.org/#/c/28022/48/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java: Line 42: response.getMetadata().add(SessionUtils.JSESSIONID_HEADER, Line 43: httpSession.getId()); Line 44: } Line 45: } Line 46: sessionHelper.clean(); } new line before } ? Line 47: Line 48: // Here to ease mocking it in the tester Line 49: protected HttpSession getCurrentSession(boolean create) { Line 50: return SessionUtils.getCurrentSession(create); http://gerrit.ovirt.org/#/c/28022/48/frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml File frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml: Line 70: </filter> Line 71: <filter-mapping> Line 72: <filter-name>SessionMgmtFilter</filter-name> Line 73: <url-pattern>/*</url-pattern> Line 74: </filter-mapping> keep same indent as rest of this file? Line 75: Line 76: <filter-mapping> Line 77: <filter-name>LocaleFilter</filter-name> Line 78: <url-pattern>/*</url-pattern> http://gerrit.ovirt.org/#/c/28022/48/frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml File frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml: Line 73: </filter> Line 74: <filter-mapping> Line 75: <filter-name>SessionMgmtFilter</filter-name> Line 76: <url-pattern>/*</url-pattern> Line 77: </filter-mapping> keep same indent as rest of this file? Line 78: <filter-mapping> Line 79: <filter-name>LocaleFilter</filter-name> Line 80: <url-pattern>/*</url-pattern> Line 81: <dispatcher>REQUEST</dispatcher> -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 48 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
