Francesco Romani has posted comments on this change.

Change subject: core: check QEMU compatibility on livesnapshot
......................................................................


Patch Set 3: Verified+1

Verification: same as per version 1.

spotted in the engine logs:
2014-06-05 16:02:54,552 WARN  
[org.ovirt.engine.core.bll.CreateAllSnapshotsFromVmCommand] 
(http--0.0.0.0-8080-4) [202d0e83] CanDoAction of action 
CreateAllSnapshotsFromVm failed. 
Reasons:VAR__ACTION__CREATE,VAR__TYPE__SNAPSHOT,ACTION_TYPE_FAILED_QEMU_UNSUPPORTED_OPERATION

However, it must be noted that the UI is not well behaving; after the action 
performed ("OK" clicked in the create snapshot pane), the spinner keeps going 
and no feedback is given.

At best of my knowledge this is an issue, but unrelated to this patch.
For the reasons above I'm ticking Verified, but I'm ready in for any further 
verification needed.

-- 
To view, visit http://gerrit.ovirt.org/28182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8869bab587d728b67d9faa0f72fe5a3a9e8ac87
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to