Francesco Romani has posted comments on this change. Change subject: core: check QEMU compatibility on livesnapshot ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28182/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 539: // if there is no live snapshot and the vm is up - snapshot is not possible Line 540: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DATA_CENTER_VERSION_DOESNT_SUPPORT_LIVE_SNAPSHOT); Line 541: } Line 542: // it is possible, even if unlikely, that the QEMU on the host does not support live snapshotting Line 543: if (!getVdsFromRunningVm(vm).getLiveSnapshotSupport()) { > Done Well, done except the check for `vm' being null, as it is in the original code. Line 544: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_QEMU_UNSUPPORTED_OPERATION); Line 545: } Line 546: return true; Line 547: } -- To view, visit http://gerrit.ovirt.org/28182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8869bab587d728b67d9faa0f72fe5a3a9e8ac87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
