Simone Tiraboschi has posted comments on this change. Change subject: Split of engine-setup-plugin ......................................................................
Patch Set 36: (2 comments) http://gerrit.ovirt.org/#/c/27647/36/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 947: %ghost %config(noreplace) %{_sysconfdir}/firewalld/services/ovirt.xml Line 948: Line 949: %files setup-plugin-ovirt-engine-common Line 950: Line 951: %{engine_data}/setup/dbutils/ > well, I think these db-utils should go to engine only... it is the simplest but changedbowner.sh is still needed also by reports and DWH and it seams that we are still using it also on 3.5 so where I should move it? Line 952: %{engine_data}/setup/ovirt_engine_setup/engine_common/ Line 953: %{engine_data}/setup/plugins/*/ovirt-engine-common/ Line 954: Line 955: %files setup-plugin-websocket-proxy http://gerrit.ovirt.org/#/c/27647/36/packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py File packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py: Line 330: Line 331: @util.export Line 332: @util.codegen Line 333: @osetupattrsclass Line 334: class ApacheEnv(object): > we will need to modify this plugin behaviour, as the reports will also requ I see: reports has its own oreportscons.ApacheEnv class so I'm going to had an oenginecons.ApacheEnv class for engine specific apache stuff keeping here only what's really common (NEED_RESTART for instance as you cannon restart half apache). Line 335: Line 336: HTTPD_SERVICE = 'OVESETUP_APACHE/httpdService' Line 337: Line 338: HTTPD_CONF_SSL = 'OVESETUP_APACHE/configFileSsl' -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 36 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
