Simone Tiraboschi has posted comments on this change. Change subject: Split of engine-setup-plugin ......................................................................
Patch Set 36: (4 comments) http://gerrit.ovirt.org/#/c/27647/36/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 947: %ghost %config(noreplace) %{_sysconfdir}/firewalld/services/ovirt.xml Line 948: Line 949: %files setup-plugin-ovirt-engine-common Line 950: Line 951: %{engine_data}/setup/dbutils/ > the following are engine specific: Is it better to simply move them within this spec file or to create a different folder (eg. enginedbutils) just for them? Line 952: %{engine_data}/setup/ovirt_engine_setup/engine_common/ Line 953: %{engine_data}/setup/plugins/*/ovirt-engine-common/ Line 954: Line 955: %files setup-plugin-websocket-proxy http://gerrit.ovirt.org/#/c/27647/36/packaging/setup/ovirt_engine_setup/engine/engineconstants.py File packaging/setup/ovirt_engine_setup/engine/engineconstants.py: Line 26: Line 27: from otopi import util Line 28: Line 29: Line 30: from . import engineconfig > import of . should go last and within own block Done Line 31: from ovirt_engine_setup import constants as osetupcons Line 32: from ovirt_engine_setup.constants import osetupattrsclass Line 33: from ovirt_engine_setup.constants import osetupattrs Line 34: http://gerrit.ovirt.org/#/c/27647/36/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 192: def _closeup(self): Line 193: self.logger.debug('Connecting to the Engine') Line 194: engine_api = self._waitEngineUp() Line 195: Line 196: vdc = vdcoption.VdcOption( > you do not need this vdc temp variable... :) Done Line 197: statement=self.environment[ Line 198: oengcommcons.EngineDBEnv.STATEMENT Line 199: ] Line 200: ) http://gerrit.ovirt.org/#/c/27647/36/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py: Line 177: ], Line 178: port=self.environment[ Line 179: oenginecons.ConfigEnv.WEBSOCKET_PROXY_PORT Line 180: ], Line 181: ) > please remove this for now, we are not working on splitting websocket proxy Done Line 182: ) Line 183: Line 184: self.execute( Line 185: args=( -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 36 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
