Francesco Romani has posted comments on this change. Change subject: Filter Windows HotFixes by ReleaseType value ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28278/4/ovirt-guest-agent/GuestAgentWin32.py File ovirt-guest-agent/GuestAgentWin32.py: Line 335: if cur_key_value.find("Software Update") >= 0: Line 336: continue Line 337: if cur_key_value.find("Update") >= 0: Line 338: continue Line 339: cur_key_value = QueryStringValue(cur_key, u'ParentKeyName') Even though I read the commit message, I'm still not sure it is OK to unconditionally overwrite the cur_key_value here. Maybe an else (and or move all the above if()s in a single if() using `or') would lead to clearer code? Line 340: if cur_key_value.find("OperatingSystem") >= 0: Line 341: continue Line 342: cur_key_value = QueryStringValue(cur_key, u'DisplayName') Line 343: if len(cur_key_value) == 0: -- To view, visit http://gerrit.ovirt.org/28278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ab40ed538a48d79f30ee300d791ce4636371634 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Tomáš Došek <tdo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
