Vinzenz Feenstra has posted comments on this change.

Change subject: Filter Windows HotFixes by ReleaseType value
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/28278/5/ovirt-guest-agent/GuestAgentWin32.py
File ovirt-guest-agent/GuestAgentWin32.py:

Line 334:                     continue
Line 335:                 if release_type.find("Software Update") >= 0:
Line 336:                     continue
Line 337:                 if release_type.find("Update") >= 0:
Line 338:                     continue
> what about
Will make a follow up for the cleanup
Line 339:                 parent_key_name = QueryStringValue(cur_key, 
u'ParentKeyName')
Line 340:                 if parent_key_name.find("OperatingSystem") >= 0:
Line 341:                     continue
Line 342:                 display_name = QueryStringValue(cur_key, 
u'DisplayName')


-- 
To view, visit http://gerrit.ovirt.org/28278
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab40ed538a48d79f30ee300d791ce4636371634
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdo...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to