Alon Bar-Lev has posted comments on this change. Change subject: Split of engine-setup-plugin ......................................................................
Patch Set 32: (4 comments) http://gerrit.ovirt.org/#/c/27647/32/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 379: @util.export Line 380: @util.codegen Line 381: @osetupattrsclass Line 382: class PKIEnv(object): Line 383: ENGINE_RSA_PUBLIC_KEY = 'OVESETUP_PKI/engineRSAPublicKey' this should not be in common Line 384: Line 385: Line 386: @util.export Line 387: @util.codegen http://gerrit.ovirt.org/#/c/27647/32/packaging/setup/ovirt_engine_setup/engine/engineconstants.py File packaging/setup/ovirt_engine_setup/engine/engineconstants.py: Line 30: Line 31: from . import engineconfig Line 32: from ovirt_engine_setup import constants as osetupcons Line 33: from ovirt_engine_setup.constants import \ Line 34: classproperty, osetupattrsclass, osetupattrs please use multiple imports Line 35: Line 36: Line 37: @util.export Line 38: class FileLocations(object): http://gerrit.ovirt.org/#/c/27647/32/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: the vdc options stuff should be moved to own file Line 1: # Line 2: # ovirt-engine-setup -- ovirt engine setup Line 3: # Copyright (C) 2013 Red Hat, Inc. Line 4: # http://gerrit.ovirt.org/#/c/27647/32/packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py File packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py: Line 30: Line 31: from . import enginecommonconfig Line 32: from ovirt_engine_setup import constants as osetupcons Line 33: from ovirt_engine_setup.constants import \ Line 34: classproperty, osetupattrsclass, osetupattrs please use multiple imports Line 35: Line 36: Line 37: @util.export Line 38: class FileLocations(object): -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
