Sandro Bonazzola has posted comments on this change.

Change subject: Split of engine-setup-plugin
......................................................................


Patch Set 31:

(1 comment)

http://gerrit.ovirt.org/#/c/27647/31/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/connection.py
File 
packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/connection.py:

Line 32: 
Line 33: 
Line 34: from ovirt_engine_setup import constants as osetupcons
Line 35: from ovirt_engine_setup.engine import engineconstants as oenginecons
Line 36: # TODO: ES: wrong fix it!!!
What about this?^^
Line 37: from ovirt_engine_setup.engine_common \
Line 38:     import enginecommonconstants as oengcommcons
Line 39: from ovirt_engine_setup.engine_common import database
Line 40: 


-- 
To view, visit http://gerrit.ovirt.org/27647
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to