Oved Ourfali has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 42: (3 comments) http://gerrit.ovirt.org/#/c/28022/42/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LogoutUserCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LogoutUserCommand.java: Line 41: Authn.InvokeKeys.PRINCIPAL, Line 42: SessionDataContainer.getInstance().getPrincipal(getParameters().getSessionId()) Line 43: )); Line 44: } Line 45: See findbugs warning on the change below. Both if and else statement do the same thing. Line 46: if (!"".equals(getParameters().getSessionId())) { Line 47: SessionDataContainer.getInstance().removeSession(getParameters().getSessionId()); Line 48: } else { Line 49: SessionDataContainer.getInstance().removeSession(getParameters().getSessionId()); http://gerrit.ovirt.org/#/c/28022/42/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Validator.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Validator.java: Line 15: */ Line 16: Line 17: package org.ovirt.engine.api.common.security.auth; Line 18: Line 19: public interface Validator { do we still need this interface? Line 20: http://gerrit.ovirt.org/#/c/28022/42/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java: Line 54: log.debug("Initializing servlet!"); //$NON-NLS-1$ Line 55: } Line 56: Line 57: @Override Line 58: public VdcQueryReturnValue RunQuery(VdcQueryType search, seems like it was already renamed to runQuery, so you might have conflicts when rebasing. Line 59: VdcQueryParametersBase searchParameters) { Line 60: log.debug("Server: RunQuery invoked!"); //$NON-NLS-1$ Line 61: debugQuery(search, searchParameters); Line 62: searchParameters.setSessionId(getEngineSessionId()); -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 42 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
