Yair Zaslavsky has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 44: 1. "HTTP header names (strings such as "Authorization" or "WWW-Authenticate") should become constants in FiltersHelper" - Ok, I will change 3. "working with InitialContext like this..." - I disagree here, IMHO we should use the bean in the JNDI context. 4, "it would be nice to have all "private static Log" + "private static ThreadLocal" marked as final too" - Done 5. Thanks for the tip, IMHO this will be an overkill here + the initialization depends on the caps field which is retreived by the request. I do not want to pass getInstance the "caps" value. 6, "usage of java.lang.Object in LoginUserParameters ... " - No need for this when used from GUI, the field is not passed. 7, "in GenericApiGWTServiceImpl replace "ovirt_aaa_engineSessionId" with SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY" - done 8, in GwtDynamicHostPageServlet extract "request.getSession().getAttribute(SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY)" into protected getEngineSessionId method for subclasses to reuse 9, in WebAdminHostPageServlet replace "request.getSession().getAttribute(SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY)" with getEngineSessionId method defined in parent class (see above) 8 & 9 - Done. -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
