Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Allow dwh on separate host ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27516/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh-common/db/connection.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh-common/db/connection.py: Line 110: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 111: name=odwhcons.Stages.DB_CONNECTION_CUSTOMIZATION, Line 112: condition=lambda self: ( Line 113: self.environment[odwhcons.CoreEnv.ENABLE] or Line 114: self.environment[odwhcons.DBEnv.CREDS_NEEDED] > Please detail exactly what you want. the environment is set, components can peek within environment, adding a variable of "CREDS_NEEDED" is something that seems duplicity. the entire idea is to ask what you do not have, this regardless of provisioning, which actually does the same. dwh and reports can peek db vars, if no set ask. I think we discussed that... moving this interaction as utility so that no code duplication is needed, just state what environment and interaction follows. this will reduce the code at dwh/reports, and will enable them to prompt easier for required database credentials. Line 115: ), Line 116: before=( Line 117: osetupcons.Stages.DIALOG_TITLES_E_DATABASE, Line 118: ), -- To view, visit http://gerrit.ovirt.org/27516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06fc960481af258b3954a8968be3439393d3ebdb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
