Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Allow dwh on separate host ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27516/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh-common/db/connection.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh-common/db/connection.py: Line 110: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 111: name=odwhcons.Stages.DB_CONNECTION_CUSTOMIZATION, Line 112: condition=lambda self: ( Line 113: self.environment[odwhcons.CoreEnv.ENABLE] or Line 114: self.environment[odwhcons.DBEnv.CREDS_NEEDED] > I think that reports should just prompt for what it needs, as if dwh is 3rd Please detail exactly what you want. Should it store the values with same keys as dwh does? Or its own keys? Should they be scheduled so that we do not ask twice? How does that apply to Engine's creds? Currently they are "always" asked, by packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py . If not populated by provisioning. in that case it also emits a message implying the user should create a new db, which is not the case if we currently setup e.g. dwh on host B where engine is already setup on host A. So we should somehow make this text changeable. Do you suggest to move also this part outside of common (and move to the engine plugin)? And make dwh and reports 'just prompt for what it needs, as if dwh is 3rd party'? Line 115: ), Line 116: before=( Line 117: osetupcons.Stages.DIALOG_TITLES_E_DATABASE, Line 118: ), -- To view, visit http://gerrit.ovirt.org/27516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06fc960481af258b3954a8968be3439393d3ebdb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
