Oved Ourfali has posted comments on this change. Change subject: core: Add kdump detection into fencing flow ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28072/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java: Line 144: getReturnValue().setSucceeded(false); Line 145: return; Line 146: } Line 147: Line 148: // kdump finished successfully, set status to Connecting and reset monitoring status You need to move the state to non-responsive and not connecting, to prevent triggering a fencing flow again. Line 149: ResourceManager.getInstance().GetVdsManager(getVds().getId()).resetStatusToConnecting( Line 150: getVds(), Line 151: true Line 152: ); -- To view, visit http://gerrit.ovirt.org/28072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18145bc5814dc0b97b8ed6593f0c76473285ae16 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
