Oved Ourfali has posted comments on this change. Change subject: core: Add kdump detection into fencing flow ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/28072/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java: Line 90: AuditLogableBase base = new AuditLogableBase(); Line 91: base.setVds(getVds()); Line 92: AuditLogDirector.log(base, AuditLogType.KDUMP_FLOW_DETECTED_ON_VDS); Line 93: Line 94: // set status to Kdumping to prevent VURTI errors and wait until kdump finishes s/VURTI/Host Monitoring It is about to change soon. Line 95: Backend.getInstance() Line 96: .getResourceManager() Line 97: .RunVdsCommand(VDSCommandType.SetVdsStatus, Line 98: new SetVdsStatusVDSCommandParameters(getVdsId(), VDSStatus.Kdumping) http://gerrit.ovirt.org/#/c/28072/6/backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties: Line 111: job.ImportRepoImage=Importing Disk ${RepoImageName} to domain ${Storage} Line 112: job.ExportRepoImage=Exporting Disk ${DiskAlias} from domain ${Storage} Line 113: job.SshSoftFencing=Executing SSH Soft Fencing on host ${VDS} Line 114: job.RemoveDiskSnapshots=Removing Disks from Snapshot(s) ${Snapshots} of VM ${VM} Line 115: job.VdsKdumpDetection=Detecting kdump flow on host ${VDS} So the kdump detection appears in the task list in the UI? afaik that's the purpose of this file. If I'm right then I don't think it should be there. Line 116: Line 117: # Step types Line 118: step.VALIDATING=Validating Line 119: step.EXECUTING=Executing -- To view, visit http://gerrit.ovirt.org/28072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18145bc5814dc0b97b8ed6593f0c76473285ae16 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
