Alon Bar-Lev has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 38: (2 comments) http://gerrit.ovirt.org/#/c/28022/38/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 482: Line 483: private static String addSessionToContext(VdcQueryParametersBase parameters) { Line 484: String sessionId = parameters.getSessionId(); Line 485: if (StringUtils.isEmpty(sessionId)) { Line 486: sessionId = ThreadLocalParamsContainer.getSessionId(); > Hi, ThreadLocalParamsContainer is used not just to store the session id on I would very like to see that! using this mechanism suggests that something is wrong in design. Line 487: } Line 488: ThreadLocalParamsContainer.setSessionId(sessionId); Line 489: return sessionId; Line 490: } http://gerrit.ovirt.org/#/c/28022/38/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetDataOnSessionParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetDataOnSessionParameters.java: Line 5: private static final long serialVersionUID = -4340219620005637644L; Line 6: private String key; Line 7: private Object value; Line 8: Line 9: public SetDataOnSessionParameters() { > checkstyle plugin enforces me to have empty CTOR. this is weired! better to ignore it than adding unneeded code. Line 10: } Line 11: Line 12: public SetDataOnSessionParameters(String key, Object value) { Line 13: this.key = key; -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
