Yair Zaslavsky has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 38: (4 comments) http://gerrit.ovirt.org/#/c/28022/38/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 105: // update his isAdmin flag accordingly Line 106: updateUserData(); Line 107: Line 108: ApplicationMode appMode = ApplicationMode.from(Config.<Integer> getValue(ConfigValues.ApplicationMode)); Line 109: SessionDataContainer.getInstance().setData("app_mode", appMode); > Hi, done. Line 110: setSucceeded(true); Line 111: } Line 112: @Override Line 113: protected boolean canDoAction() { http://gerrit.ovirt.org/#/c/28022/38/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetDataOnSessionParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetDataOnSessionParameters.java: Line 3: public class SetDataOnSessionParameters extends VdcActionParametersBase { Line 4: Line 5: private static final long serialVersionUID = -4340219620005637644L; Line 6: private String key; Line 7: private Object value; > these can be final. see my later comment. Line 8: Line 9: public SetDataOnSessionParameters() { Line 10: } Line 11: http://gerrit.ovirt.org/#/c/28022/38/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetValueBySessionQueryParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetValueBySessionQueryParameters.java: Line 6: /** Line 7: * Line 8: */ Line 9: private static final long serialVersionUID = 6548937521017309017L; Line 10: private String key; > this can be final. see comments on checkstyle plugin. Line 11: Line 12: public GetValueBySessionQueryParameters() { Line 13: } Line 14: http://gerrit.ovirt.org/#/c/28022/38/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java: Line 188: params.setActionType(loginType); Line 189: VdcLoginReturnValueBase returnValue = (VdcLoginReturnValueBase) getBackend().login(params); Line 190: if (returnValue.getSucceeded()) { Line 191: this.getThreadLocalResponse().addHeader("OVIRT-SSO-TOKEN", getSession().getId()); //$NON-NLS-1$ Line 192: getSession().setAttribute("ovirt_aaa_engineSessionId", returnValue.getSessionId()); //$NON-NLS-1$) > not accessible via FRONTEND, and have some REST-API specific code. added in common SessionConstants. Line 193: } Line 194: return returnValue; Line 195: } Line 196: -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
