Yair Zaslavsky has posted comments on this change. Change subject: aaa: add namespace for directory entities ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/28217/5/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 188: } Line 189: Line 190: private static void queryImpl( Line 191: final ExtensionProxy extension, Line 192: String namespace, final ExtMap input, > each parameter at one line, or all at long... do not mix styles... :) Done Line 193: final QueryResultHandler handler Line 194: ) { Line 195: Object opaque = extension.invoke( Line 196: new ExtMap().mput( http://gerrit.ovirt.org/#/c/28217/5/packaging/dbscripts/upgrade/03_05_0560_aaa_add_namespace.sql File packaging/dbscripts/upgrade/03_05_0560_aaa_add_namespace.sql: Line 2: select fn_db_add_column('ad_groups', 'namespace', 'varchar(2048) default NULL'); Line 3: Line 4: Line 5: Line 6: > - Done http://gerrit.ovirt.org/#/c/28217/5/packaging/dbscripts/user_sp.sql File packaging/dbscripts/user_sp.sql: Line 22: v_username VARCHAR(255), Line 23: v_group_ids VARCHAR(2048), Line 24: v_external_id TEXT, Line 25: v_namespace VARCHAR(2048)) Line 26: > - Done Line 27: RETURNS VOID Line 28: AS $procedure$ Line 29: BEGIN Line 30: INSERT INTO users(department, domain, email, groups, name, note, role, active, surname, user_id, username, group_ids, external_id,namespace) -- To view, visit http://gerrit.ovirt.org/28217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99b5611d4a05a18b271bde61a9d5be14007fd9a4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
