Alon Bar-Lev has posted comments on this change. Change subject: aaa: add namespace for directory entities ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28217/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 174 Line 175 Line 176 Line 177 Line 178 shouldn't this be changed? Line 116: filter Line 117: ); Line 118: if (namespace != null) { Line 119: inputMap.put(Authz.InvokeKeys.NAMESPACE, namespace); Line 120: } no problem to put null... it will remove from map. Line 121: Line 122: return populatePrincipals( Line 123: extension, Line 124: inputMap); -- To view, visit http://gerrit.ovirt.org/28217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99b5611d4a05a18b271bde61a9d5be14007fd9a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
