Alon Bar-Lev has posted comments on this change. Change subject: Split of engine-setup-plugin ......................................................................
Patch Set 23: (1 comment) ok, apart from this minor comment, it looks good, it is the base to continue, please move the dwh/reports constants as well in same manner so we be consistent. next phase is fixing the engine-cleanup to allow cleanup layered component. http://gerrit.ovirt.org/#/c/27647/23/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 918: %{engine_data}/setup/bin/ovirt-engine-remove Line 919: %{engine_data}/setup/bin/ovirt-engine-rename Line 920: %{engine_data}/setup/bin/ovirt-engine-setup Line 921: %{engine_data}/setup/bin/ovirt-engine-setup.env Line 922: %{engine_data}/setup/ovirt_engine_setup/*.py* you still need to own directory. %dir %{engine_data}/setup/ovirt_engine_setup Line 923: %{engine_data}/setup/plugins/*/base/ Line 924: %{engine_state}/backups/ Line 925: %{engine_state}/setup/ Line 926: -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
