Simone Tiraboschi has posted comments on this change. Change subject: Split of engine-setup-plugin ......................................................................
Patch Set 22: (3 comments) http://gerrit.ovirt.org/#/c/27647/22/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 924: %{engine_data}/setup/ovirt_engine_setup/constants.* Line 925: %{engine_data}/setup/ovirt_engine_setup/dialog.* Line 926: %{engine_data}/setup/ovirt_engine_setup/domains.* Line 927: %{engine_data}/setup/ovirt_engine_setup/firewall_manager_base.* Line 928: %{engine_data}/setup/ovirt_engine_setup/util.* > this is why I would like a directory per sub package Done, %{engine_data}/setup/ovirt_engine_setup/*.py* should be enough for base Line 929: %{engine_data}/setup/plugins/*/base/ Line 930: %{engine_state}/backups/ Line 931: %{engine_state}/setup/ Line 932: Line 943: %{engine_data}/conf/ovirt-engine-root-redirect.conf.in Line 944: %{engine_data}/firewalld/ovirt-engine/ Line 945: %{engine_data}/setup/bin/ovirt-engine-upgrade-check Line 946: %{engine_data}/setup/ovirt_engine_setup/engineconfig.* Line 947: %{engine_data}/setup/ovirt_engine_setup/engineconstants.* > .py* please... but see above. Done Line 948: %{engine_data}/setup/plugins/*/ovirt-engine/ Line 949: Line 950: # backward compatibility Line 951: # backward compatibility (pre-3.4) Line 953: %ghost %config(noreplace) %{_sysconfdir}/firewalld/services/ovirt.xml Line 954: Line 955: %files setup-plugin-ovirt-engine-common Line 956: Line 957: %{engine_data}/setup/dbutils/ > this is of engine only I think...^ Shouldn't DWH and Reports manage a DB too? Line 958: %{engine_data}/setup/ovirt_engine_setup/enginecommonconstants.* Line 959: %{engine_data}/setup/ovirt_engine_setup/database.* Line 960: %{engine_data}/setup/ovirt_engine_setup/postgres.* Line 961: %{engine_data}/setup/plugins/*/ovirt-engine-common/ -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
