Yair Zaslavsky has posted comments on this change. Change subject: aaa: Intorduce filters ......................................................................
Patch Set 35: (2 comments) http://gerrit.ovirt.org/#/c/28022/35/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java: Line 152: ExtMap authRecord = output.<ExtMap> get(Authn.InvokeKeys.AUTH_RECORD); Line 153: req.setAttribute(FiltersHelper.Constants.REQUEST_AUTH_RECORD_KEY, authRecord); Line 154: req.setAttribute(FiltersHelper.Constants.REQUEST_PROFILE_KEY, profile); Line 155: session.removeAttribute(STACK_ATTR); Line 156: stack.clear(); stack must be cleared here, no point in continue to next profile. Line 157: break; Line 158: Line 159: case Authn.AuthResult.NEGOTIATION_UNAUTHORIZED: Line 160: moveToNextProfile(session, stack); Line 159: case Authn.AuthResult.NEGOTIATION_UNAUTHORIZED: Line 160: moveToNextProfile(session, stack); Line 161: break; Line 162: Line 163: case Authn.AuthResult.NEGOTIATION_INCOMPLETE: not moving to next profile until incomplete. please elaborate on what is missing here. Line 164: break; Line 165: Line 166: default: Line 167: log.error(String.format("Unexpected authentication result. AuthResult code is %1$s", -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
