Yair Zaslavsky has posted comments on this change. Change subject: aaa: Intorduce filters ......................................................................
Patch Set 32: (3 comments) http://gerrit.ovirt.org/#/c/28022/32/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java: Line 104: if (!profiles.isEmpty()) { Line 105: // Perform the authentication: Line 106: doAuth((HttpServletRequest) req, (HttpServletResponse) rsp, chain); Line 107: } Line 108: chain.doFilter(req, rsp); > I think you need to go into doFilter only if you completed the stack. isnt it what the while loop in doAuth supposed to do? it ends when the stack is empty. Line 109: } Line 110: Line 111: private void doAuth(HttpServletRequest req, HttpServletResponse rsp, FilterChain chain) Line 112: throws IOException, ServletException { http://gerrit.ovirt.org/#/c/28022/32/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java: Line 54: } Line 55: } Line 56: doFilter = true; Line 57: } catch (Exception ex) { Line 58: doFilter = false; > no need. Done Line 59: String msg = Line 60: String.format("An error has occurred while session validation. Message is %1$s", ex.getMessage()); Line 61: log.error(msg); Line 62: if (log.isDebugEnabled()) { Line 55: } Line 56: doFilter = true; Line 57: } catch (Exception ex) { Line 58: doFilter = false; Line 59: String msg = > remove temp variable? Done Line 60: String.format("An error has occurred while session validation. Message is %1$s", ex.getMessage()); Line 61: log.error(msg); Line 62: if (log.isDebugEnabled()) { Line 63: log.debug("", ex); -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
