Arik Hadas has posted comments on this change. Change subject: engine : Introduction of CommandExecutor and AsyncCommandCallBack ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28154/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 49: final CommandCallBack callBack) { Line 50: VdcReturnValueBase result = getBackendCommandObjectsHandler().runAction(command, null); Line 51: if (callBack != null) { Line 52: if (result.getSucceeded()) { Line 53: command.setCommandStatus(CommandStatus.SUCCEEDED); shouldn't it be active? Line 54: } Line 55: callBack.setExecutionResult(result); Line 56: } Line 57: } http://gerrit.ovirt.org/#/c/28154/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java: Line 2: Line 3: import org.ovirt.engine.core.common.action.VdcReturnValueBase; Line 4: Line 5: public interface CommandCallBack { Line 6: public abstract void setExecutionResult(VdcReturnValueBase result); why abstract? I would suggest to rename the method to something like executionEnded or executed (like in IFrontendActionAsyncCallback) because it is not a 'setter' but event that it fired when the execute stage is done -- To view, visit http://gerrit.ovirt.org/28154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70922b5b836971eca76dee26ba67b7023d546fe6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
